GitHub activity
Loading activity…
Hey @xam-dev-ux, thank you for the contribution! The earlier review's ask is addressed: the diagram now uses @Toby1009's suggested version with line breaks, the...
Hey @davidatwhiletrue, thank you for the contribution! This branch currently conflicts with main, so please rebase it onto current main first. I did a pass over...
(migration: approved on GitHub; no ping posted)
Hey @phdargen, thank you for the contribution! The managed custody port reads cleanly against the EVM batch-settlement spec and the test coverage is thorough. +...
Hey @saneGuy, thank you for the contribution! 1. The PR description says "28/28 (23 unit, 5 integration)", but on the current head typescript/packages/extension...
Hey @nniiovoo, thank you for the contribution! The Path 1 passthrough looks right to me: topLevelPrograms already drops ComputeBudget and Memo, the new branch o...
Hey @phdargen, thank you for the contribution! The dependency set in go/go.mod matches the current patched releases (Echo v4.16.2, MCP SDK v1.8.0, quic-go v0.64...
Hey @rotilho, thank you for the contribution! This is a focused v2 exact spec for Atto: facilitator-relayed native SEND, decimal-string wire profile, numbered v...
Hey @Khelechy, thank you for the contribution! 1. EvmSchemes.Exact in dotnet/src/X402.Mechanisms.Evm/Constants.cs is "evm-exact", but the v2 spec and the e2e te...
Hey @jonathanbulkeley, thank you for the contribution! 1. The file was added at specs/extensions/specs/extensions/diagnostic.md (the path is doubled). Could it...
Hey @mfix-stripe, thank you for the contribution! 1. constants.rb lists MegaUSD on eip155:4326 as an EIP-3009 asset. The Python and Go SDKs set permit2 for it,...
Hey @asghaier76, thank you for the contribution! 1. schemesubscribeevm.md §10.5 shows the /supported response as a supported array. SupportedResponse in specs/x...
Hey @epistemedeus, thank you for the contribution! 1. The description says the Go example is limited to identifier injection, but examples/go/clients/payment-id...
Hey @phdargen, thank you for the contribution! The examples lint/format discovery failure looks resolved on this head (pnpm -r scripts and turbo@^2.9.14), and t...
Hey @notorious-d-e-v, thank you for the contribution! Apologies for the delay 🙏 This fills a real accounting gap by firing onDistributionConfirmed on cooperati...
Hey @PhilBot402, thank you for the contribution! 1. GitHub reports this branch as conflicting with main. Please rebase and resolve the conflicts so the checks r...
Hey @phdargen, thank you for the contribution! 1. check-lint-examples-typescript and check-format-examples-typescript fail in discovery with Workspace package r...
Hey @mikedotexe, thank you for the contribution! 1. settlementMargin in the deadline rule (deadline <= now + settlementMargin) isn't defined anywhere in the rep...
Hey @cipherwebllc, thank you for the contribution! 1. Please extend the facilitator verification section to match schemeexactevm.md. Add MUSTs for accepted.amou...
Hey @whawk46, thank you for the contribution! 1. Please add a JSON Schema schema block alongside info for xrplFeeSponsoring (covering sponsor, mode, maxFee), as...
Hey @sukrutkrdg, thank you for the contribution! 1. Please rebase onto current main. As-is, the branch would drop the newer Verify and Settlement Response Sidec...
Hey @notorious-d-e-v, thank you for the contribution! Thanks for the rebase and the second commit. On bde6af6, all four earlier inline points are addressed: the...
Hey @phdargen, thank you for the contribution! 1. A landed deposit whose voucher commit fails still drops transaction from the failure receipt (go/http/server.g...
Hey @Eras256, thank you for the contribution! This passes my review, @CarsonRoscoe please take a look. One small ask: please update the PR description's Fix sec...
Hey @notorious-d-e-v, thank you for the contribution! This is a nice quality-of-life fix. Forwarding invalidMessage into SettleResponse.errorMessage at each set...
Hey @Eras256, thank you for the contribution! This passes my review, @CarsonRoscoe please take a look.
Hey @PhilBot402, thank you for the contribution! This brings the Python clients in line with the Go (#2973) and TypeScript (#3400) body caps, with a changelog f...
Hey @rotilho, thank you for the contribution! A few things before it is ready: 1. Numbered verification rules. The Facilitator Verification Rules are bullet lis...
Hey @Niri7981, thank you for the contribution! The async x402MCPSession path wiring paid tool results through handlepaymentresponse with a single corrective-402...
Hey @kakedashi3, thank you for the contribution! This is a focused TypeScript port of the Go #2454 low-s hardening for EIP-3009 verify: the helper, error wire v...
Hey @PhilBot402, thank you for the contribution! This is a port of #3459. Verified on this head: the exact, upto and batch-settlement clients call warncannotrea...
Hey @PhilBot402, thank you for the contribution! This is a port of #3668. Verified on this head: Gin, Echo and net/http write a declared text/plain string body...
Hey @PhilBot402, thank you for the contribution! This is a port of #3668. Verified on this head: Flask and FastAPI send a string body as raw text when the decla...
Hey @agnij-dutta, thank you for the contribution! Verified on this head: x402MCPClientSync regains onpaymentrequired, onbeforepayment, onafterpayment, calltoolw...
Hey @parthod0x, thank you for the contribution! Verified on this head: @x402/stellar now requires @stellar/stellar-sdk ^16.4.1, and all three lockfiles (typescr...
Hey @asooge, thank you for the contribution! This is a solid reflected-XSS fix for the TypeScript paywall generators: request-derived config now goes through sc...
Hey @PhilBot402, thank you for the contribution! This is a port of #3285. Verified on this head: V2 PaymentRequirements.network now uses NetworkV2, applying the...
Hey @PhilBot402, thank you for the contribution! This is a port of #3567. Verified on this head: resolvedeclaredmethod keeps the probe method only when it fits...
Hey @PhilBot402, thank you for the contribution! This is a port of #3338. Verified on this head: ResolveSettlementOverrideAmount now resolves to a big.Int and r...
Hey @PhilBot402, thank you for the contribution! This is a port of #3338. Verified on this head: resolvesettlementoverrideamount() resolves raw, percent and dol...
Hey @PhilBot402, thank you for the contribution! This is a port of #3795. Verified on this head: createhttpresponse returns {"error": paymentrequired.error} onl...
Hey @damiafuentes, thank you for the contribution! This is a focused, spec-first reviews extension: links only on PaymentRequired and SettlementResponse, facili...
Hey @notorious-d-e-v, thank you for the contribution! The follow-up on this head looks good. completeSealDistribution now coalesces in-flight accounting through...
Hey @notorious-d-e-v, thank you for the contribution! Here's where the earlier review at 5ecf64d stands on head 2c11ea59: 1. Overlap with #3855 is addressed. Th...
Hey @boboliu-1010, thank you for the contribution! Since 4c0ac085, the new Exact Proxy Source and Verification (Informative) section and the reproduction script...
Hey @nniiovoo, thank you for the contribution! Verified on this head: getauthheaders now checks collections.abc.Mapping for both the path-key detection and the...
Hey @lgalabru, thank you for the contribution! The update to 2a21f8d addresses both nits from the earlier review: the parent Multi-Payee client-verification rul...
Hey @boboliu-1010, thank you for the contribution! On the open question of which TRON x402ExactPermit2Proxy deployments the spec should pin (cc @ukstv): the dec...
Hey @CarsonRoscoe, thank you for the contribution! 1. (non-blocking) In schemeexactsvm.md, §3.1 and §3.1.1 still describe the new Lighthouse-policy and allowlis...